Fix conditional configuration options usage#1871
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom May 28, 2023
Merged
Fix conditional configuration options usage#1871apoelstra merged 2 commits intorust-bitcoin:masterfrom
apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
We no longer need to use `doc(cfg())` because we use `doc_cfg_auto`, remove it.
Our custom conditional configuration options enables for various versions of the compiler are not features. Fix the incorrect usage.
apoelstra
approved these changes
May 24, 2023
Member
Author
|
cc @yancyribbens just FYI. |
Kixunil
approved these changes
May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These build cfg options are not features, fix broken usage. And remove stale docsrs attribute while we are at it. Bad rust-bitcoin devs.
Found while reviewing #1870