Skip to content

ci: fix -run syntax#1842

Merged
apoelstra merged 1 commit intomasterfrom
2023-05--fix-ci
May 10, 2023
Merged

ci: fix -run syntax#1842
apoelstra merged 1 commit intomasterfrom
2023-05--fix-ci

Conversation

@apoelstra
Copy link
Copy Markdown
Member

@apoelstra apoelstra commented May 8, 2023

I think our CI failures started with #1821 when we added an extra run: line to fuzz.yml without prefixing it with -.

Fix the syntax to use a multi-line run instead.

@apoelstra
Copy link
Copy Markdown
Member Author

Ok, the debug echo shows that we're not actually setting the variable.

@apoelstra
Copy link
Copy Markdown
Member Author

CI failure is now because #1841 needs to be merged.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this pipe do? It's not a valid bash syntax.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to print the RUSTFLAGS here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, oops, I fixed this but forgot to push last night.

Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a1aaf5f

Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a1aaf5f

@apoelstra apoelstra merged commit 4fc6a6a into master May 10, 2023
@apoelstra apoelstra deleted the 2023-05--fix-ci branch May 10, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants