Use package in manifest and shorten import#1742
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Apr 5, 2023
Merged
Use package in manifest and shorten import#1742apoelstra merged 1 commit intorust-bitcoin:masterfrom
apoelstra merged 1 commit intorust-bitcoin:masterfrom
Conversation
26260a8 to
133841d
Compare
bdcd10d to
a69f701
Compare
sanket1729
previously approved these changes
Mar 24, 2023
Member
sanket1729
left a comment
There was a problem hiding this comment.
ACK a69f70162230d3343294db9ad61380169ed2ec13
Kixunil
previously approved these changes
Mar 24, 2023
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
ACK a69f70162230d3343294db9ad61380169ed2ec13
a69f701 to
6f905fc
Compare
Member
Author
|
Fixed schemars test by not changing the |
apoelstra
previously approved these changes
Mar 28, 2023
Member
apoelstra
left a comment
There was a problem hiding this comment.
ACK 6f905fc4a8178ba7c6dc1c07efbb1eb60cd51a11
We can use `package` to rename `bitcoin_hashes` to `hashes` and `bitcoin_internals` to `internals`. This makes imports more terse with no loss of meaning.
6f905fc to
fabcde0
Compare
apoelstra
approved these changes
Mar 28, 2023
Member
Author
|
@Kixunil and @sanket1729 you guys have ack'd but not approved, could you hit that button please. |
Kixunil
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use
packageto renamebitcoin_hashestohashesandbitcoin_internalstointernals. This makes imports more terse with no loss of meaning.