Skip to content

Fix CI builds where default features are added accidentally#1708

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
stevenroose:ci-no-std-fix
Mar 13, 2023
Merged

Fix CI builds where default features are added accidentally#1708
apoelstra merged 1 commit intorust-bitcoin:masterfrom
stevenroose:ci-no-std-fix

Conversation

@stevenroose
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9dd4c54

@Kixunil Kixunil added bug ci trivial Obvious, easy and quick to review (few lines or doc-only...) one ack PRs that have one ACK, so one more can progress them labels Mar 12, 2023
@Kixunil
Copy link
Copy Markdown
Collaborator

Kixunil commented Mar 12, 2023

Hey @stevenroose, I'm happy you're not dead or something. I can understand that you may not have time to process bitcoincore-rpc but could you at least give someone else permission to merge and upload the crate?

Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9dd4c54

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9dd4c54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants