Closed
Conversation
Currently we run a bunch of unit tests that check the state of data structures during hashing however we hobble these data structures when fuzzing so the tests fail and are meaningless. Exclude unit tests that test state if fuzzing.
Member
|
We should fix the unit tests so that they pass with |
Member
Author
|
ok cheers, so my suspicion that I was being brain dead was correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we run a bunch of unit tests that check the state of data structures during hashing however we hobble these data structures when fuzzing so the tests fail and are meaningless.
Exclude unit tests that test state if fuzzing.
Fix: #1409
I'm not totally sure I'm not being brain dead here but I think this is the problem :)