amount: use Kani to prove some arithmetic properties#1415
Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom Nov 28, 2022
Merged
amount: use Kani to prove some arithmetic properties#1415apoelstra merged 2 commits intorust-bitcoin:masterfrom
apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
Kani can't really handle string processing, and appears to be unable to check integer multiplication (for now), but we do several checks for addition and subtraction, and conversion between signedness, that Kani can easily prove.
ea7370c to
d4bfc3d
Compare
tcharding
approved these changes
Nov 28, 2022
Member
|
This is totally new to me but looks like a step forward. Whats the next step, more kani tests for other modules? Do we keep the fuzzing we have or is the idea to move to Bolero (which I also no nothing about)? |
Member
Author
Yep.
We'll keep the fuzzing we have. The benefit of Bolero is that it lets us switch fuzz backends, which we don't really need, including to use a Kani backend, which I don't think really makes sense. (Fuzzers are good at open-ended search of strings and stuff, which is what Kani is horrible at.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first exploration into using Kani. See #1370.