Skip to content

Move test_data/* to tests/data#1347

Closed
tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
tcharding:10-22-move-test_data
Closed

Move test_data/* to tests/data#1347
tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
tcharding:10-22-move-test_data

Conversation

@tcharding
Copy link
Copy Markdown
Member

In preparation for adding integration tests in the standard Rust tests/ directroy; move the contents of test_data to tests/data.

This was originally part of #724 but that is proving to take an eon to merge so lets put this patch in first. Can then be used by #935 (cc @DanGould).

@tcharding tcharding changed the title Move test_data/* tests/data Move test_data/* to tests/data Oct 25, 2022
@DanGould
Copy link
Copy Markdown
Contributor

ACK 374008b

@RCasatta
Copy link
Copy Markdown
Collaborator

Remember to update the exclude field in Cargo.toml

@tcharding tcharding force-pushed the 10-22-move-test_data branch from 374008b to 0826b96 Compare October 26, 2022 22:15
@tcharding
Copy link
Copy Markdown
Member Author

Remember to update the exclude field in Cargo.toml

Ah yes, thanks man.

@tcharding
Copy link
Copy Markdown
Member Author

Force pushed fix to exclude tests/ it manifest as suggested.

In preparation for adding integration tests in the standard Rust
`tests/` directroy; move the contents of `test_data` to `tests/data`.
@tcharding tcharding force-pushed the 10-22-move-test_data branch from 0826b96 to ffad4c6 Compare October 27, 2022 23:59
@sanket1729
Copy link
Copy Markdown
Member

Oops, sorry I merged #935 which already contained this commit. We can use this PR to iterate if needed, otherwise, we can close this.

@apoelstra
Copy link
Copy Markdown
Member

I'm ok with closing.

@tcharding
Copy link
Copy Markdown
Member Author

My bad, I'll double check its all merged correctly, I made things worse trying to make them easier :)

@tcharding tcharding closed this Oct 28, 2022
@tcharding tcharding deleted the 10-22-move-test_data branch November 7, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants