Skip to content

CI clean ups#1238

Merged
apoelstra merged 4 commits intorust-bitcoin:masterfrom
tcharding:09-05-ci-clean-ups
Sep 6, 2022
Merged

CI clean ups#1238
apoelstra merged 4 commits intorust-bitcoin:masterfrom
tcharding:09-05-ci-clean-ups

Conversation

@tcharding
Copy link
Copy Markdown
Member

Clean up the CI script. These patches are part of #1225, are beneficial to have before that PR resolves, and are trivial.

There should only be a single blank line at end of file.
Setting `-ex` in the shebang makes it a little hard to see since folks
are used to glancing up and looking for `set -ex`. Both styles achieve
the same result, so this does not change the logic of the script.
shellcheck emits:

 SC2027: The surrounding quotes actually unquote this. Remove or escape them.

Remove inner quotes from shell variable so the feature is correctly printed.
Cargo already has an env var for controlling the toolchain, we should
use it instead of our current custom `TOOLCHAIn`.

While we are at it fix the missing `$` from variables (found by
`shellcheck`).

Use RUSTUP_TOOLCHAIN to allow control of the toolchain.
@tcharding tcharding added ci trivial Obvious, easy and quick to review (few lines or doc-only...) no release notes mention labels Sep 5, 2022
Copy link
Copy Markdown
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 37cd650

@sanket1729 sanket1729 added the one ack PRs that have one ACK, so one more can progress them label Sep 6, 2022
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 37cd650

@apoelstra apoelstra merged commit 5018214 into rust-bitcoin:master Sep 6, 2022
@tcharding tcharding deleted the 09-05-ci-clean-ups branch September 7, 2022 00:30
@tcharding tcharding added this to the 0.30.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci no release notes mention one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants