Merged
Conversation
There should only be a single blank line at end of file.
Setting `-ex` in the shebang makes it a little hard to see since folks are used to glancing up and looking for `set -ex`. Both styles achieve the same result, so this does not change the logic of the script.
shellcheck emits: SC2027: The surrounding quotes actually unquote this. Remove or escape them. Remove inner quotes from shell variable so the feature is correctly printed.
Cargo already has an env var for controlling the toolchain, we should use it instead of our current custom `TOOLCHAIn`. While we are at it fix the missing `$` from variables (found by `shellcheck`). Use RUSTUP_TOOLCHAIN to allow control of the toolchain.
apoelstra
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the CI script. These patches are part of #1225, are beneficial to have before that PR resolves, and are trivial.