Remove MAX_SEQUENCE constant#1171
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Aug 5, 2022
Merged
Conversation
This is follow up work to the recent addition of the `Sequence` type. We do not need to keep a public integer const for `MAX_SEQUENCE` because we offer the `Sequenc::MAX` associated type. Use the all-bits-set u64 directly in the associated type `Sequence::MAX`.
nlanson
approved these changes
Aug 5, 2022
apoelstra
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow up work to the recent addition of the
Sequencetype. Wedo not need to keep a public integer const for
MAX_SEQUENCEbecause weoffer the
Sequenc::MAXassociated type.Use the all-bits-set u64 directly in the associated type
Sequence::MAX.cc nlanson