Closed
Conversation
We only typically put a single newline between functions and types.
Done in an attempt to future proof our error types i.e., to prevent us from inadvertently, or otherwise, making breaking API changes. For all publicly exposed error types: - Remove all the derives except `Debug`. - Enforce `Send`/`Sync` using custom macro.
Kixunil
reviewed
Jul 29, 2022
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
I didn't intend to say that we should remove Clone or even PartialEq, just to think carefully about them.
| /// In an attempt to guarantee forward compatibility for error types we only derive `Debug` and we | ||
| /// use this trait to commit to `Send`/`Sync`. | ||
| #[doc(hidden)] | ||
| pub trait AssertSendSync: Send + Sync {} |
Collaborator
There was a problem hiding this comment.
I specifically didn't want it public. pub(crate) is fine.
Member
Author
|
Closing this, leaving error work for another day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: Bother, I did not see #1143 before doing this work.
Done in an attempt to future proof our error types i.e., to prevent us
from inadvertently, or otherwise, making breaking API changes.
For all publicly exposed error types:
Debug.Send/Syncusing custom macro.ref: #1127 (comment)