Remove deprecated StreamReader#1144
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Aug 1, 2022
Merged
Conversation
ac65947 to
8d7f4cb
Compare
`StreamReader` was deprecated for a while, yet we needlessly maintain it and it eats our testing time. This change removes it completely. Closes rust-bitcoin#1123
8d7f4cb to
0c9c141
Compare
tcharding
approved these changes
Aug 1, 2022
| let mut reader = StreamReader::new(&big_block[..], None); | ||
| let block: Block = reader.read_next().unwrap(); | ||
| let mut reader = &big_block[..]; | ||
| let block = Block::consensus_decode(&mut reader).unwrap(); |
Member
There was a problem hiding this comment.
I haven't groked the bench mark code in general but this function probably should be renamed to say what it is bench marking, possibly bench_block_deserialize_logic?
Collaborator
Author
There was a problem hiding this comment.
Oh, I didn't read the function name. 😅 I will have to look if it's even needed, maybe it should be removed.
Member
There was a problem hiding this comment.
Cheers, I could not work out if it was adding value or not.
Member
There was a problem hiding this comment.
My intuition is we should probably drop it. Can do this in a followup PR
apoelstra
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamReaderwas deprecated for a while, yet we needlessly maintain itand it eats our testing time. This change removes it completely.
Closes #1123