Hi @tcharding / @Kixunil - I'm having some trouble with this one. I've replaced all instances of secp256k1::Message::from_slice(_).expect(_) to secp256k1::Message::from(_). There is one particular case in which I'm getting an error:

Line 143 in cd790dc

let msg = secp256k1::Message::from_slice(&msg_hash[..])

The error I'm getting is:

error[E0277]: the trait bound `hashes::sha256d::Hash: secp256k1::ThirtyTwoByteHash` is not satisfied
   --> src/util/misc.rs:143:23
    |
143 |             let msg = secp256k1::Message::from(msg_hash);
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `secp256k1::ThirtyTwoByteHash` is not implemented for `hashes::sha256d::Hash`
    |
    = note: required because of the requirements on the impl of `std::convert::From<hashes::sha256d::Hash>` for `secp256k1::Message`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `bitcoin` due to previous error

This is confusing me because such impl does exist.

Digging deeper, I believe this might be due to a mismatch between the versions of bitcoin_hashes used in rust-bitcoin and rust-secp256k1, which are 0.11.0 and 0.10.0, respectively.

Interestingly, I think the approach taken here does not work due to 58f94be.

I'm unsure about which could be the appropriate direction here 🤔 My bet is on matching the bitcoin_hashes version, but I'd love to read your thoughts...

Use infallible conversions from hashes to secp256k1::Message #824

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Use infallible conversions from hashes to `secp256k1::Message` #824