-
Notifications
You must be signed in to change notification settings - Fork 965
Moving bunch of stuff from my payjoin crate here #630
Copy link
Copy link
Open
Description
I'm working on a PayJoin (BIP78) crate (not released yet) and I was thinking of migrating some stuff from there over here. But first I'd like to ask whether/which things you find worthy moving.
Stuff that seems to be interesting to me:
- BIP21 parsing and serializing
- Extension trait for weight calculation on
TxIn,TxOutetc, so that one may for instance predict how much transaction fee will change (would use inherent methods here) Weightdata type - newtype aroundu64for transaction weight, returned by weight-computing functionsFeeRatenewtype overu64, returned byAmount / Weight- Function for computing fee paid by PSBT (needs UTXO information of course)
- Function for computing the size of finalized PSBT
- Helper type replacing
(&bitcoin::Txin, &bitcoin::util::psbt::Input)with a method for getting previousTxOutand possibly other helpers
Questionable stuff:
IntputType- enum of possible input types (P2PK, P2PKH, P2SH, P2SH-P2W*, P2W*, P2TR), may interact nicely with WitnessVersion type #617OutputType- analogous toInputType
There's also some stuff I'd like to be helped with if someone is interested:
- writing PSBT finalizer - is someone here experienced to do it?
- reviewing my code :)
- if someone here enjoys writing tests I'd be happy to let you write them
If approved, I'd submit the changes in separate PRs.
I'm also willing to move the whole crate to this organization under the condition that I will have commit access for at least a few months during initial development (may have WIP disclaimer).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels