You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if we should have a Rust 2018 tracking issue and start tagging things that are blocked on it.
Would be good to have a clear picture of what we're missing by being on 1.29.
Use Vec::from([foo]) instead of Vec::new followed by v.push(). (Remove MSRV todo comments #952, I checked all instances of mut foo = Vec::new() and also the same for BTreeMap)
Change cause() to source() in impl of std::error::Error
— @apoelstra #373 (comment)
serdecrate/feature and prevents from using normal solutions like Replace feature serde with use-serde #373 (comment)syn1.0 support like inamplify_deriveinstead if hard-to-readimpl_macro and multipleimpl From...andimpl Display...blocks (and there are wrapper types as well https://docs.rs/amplify_derive/2.0.6/amplify_derive/derive.Wrapper.html)#[non_exhaustive]to solve the problem of breaking API changes with gated enum veriantsChecklist
async - probably only forThis is a nice to have, leave for another day.ReadandWriteasync equivalentsuse-serderenamed toserde#1006useThis is a nice to have, leave for another day.amplify_derive? note that this will blow up compile times for non-serde usesTryFromand useTryInto(Implement TryFrom #1007 doesTryFrombut not theTryIntobit)sort_by_cached_keyimpl PartialOrd/Ord for PublicKey #524Add PublicKey::to_sort_key method for use with sorting by key #1084Usealloc? Is this still relevant?Infallible(Remove Uninhabited #1075)contains()on ranges Add OP_CHECKSIGADD and OP_SUCCESSxxx #644 (comment) (Remove MSRV todo comments #952)chunks_exact()instead ofchunks(Remove MSRV todo comments #952)use Trait as _(Remove unnecessaryWrite as _fmtWrite#965)Exhaustive integer matching instead of comparing with zero(improves readability) (Match on specific integer values #1012)(;)?instead of(;)*in macros (Addamount::Display- make formatting configurable #716) (Match against an optional single trailing colon #1010)literalinstead ofexprin macros (Addamount::Display- make formatting configurable #716) (Use fragment-specifier literal #1014)trim_start_matchesinstead oftrim_left_matches(Remove MSRV todo comments #952)Vec::from([foo])instead ofVec::newfollowed byv.push(). (Remove MSRV todo comments #952, I checked all instances ofmut foo = Vec::new()and also the same forBTreeMap)cause()tosource()in impl ofstd::error::Erroru16::to_be_bytesinstead ofswap_bytes(Remove MSRV todo comments #952)#[non_exhaustive](Add non_exhaustive compiler directive toAddressType#1011 and Add non_exhaustive to all error enums #1026)non_exhaustivetypes:Error(Add non_exhaustive to all error enums #1026)AddressType(Add non_exhaustive compiler directive toAddressType#1011)address::Payload(Add non_exhaustive compiler directive toAddressType#1011)LeafVersion(Add non_exhaustive compiler directive toAddressType#1011)PR list:
Edition 2018 #635closed in favour of 983