Skip to content

The sha256t_hash_newtype! call in the taproot module is unclear #2811

@tcharding

Description

@tcharding

Raising an issue instead of a PR in case I'm just being overly sensitive. The macro call in the taproot module declares six types in a single go, as such (and because of the rustdocs layout) its not obvious which goes with which and I find myself having to remember to pair them. It doesn't help that the hash for TapBranchTag is called TapNodeHash instead of being uniform and using TapBranchHash like the other two.

Should we:

  • Remove the repetition in the macro and call it three times so the grouping is obvious?
  • Rename the TapNodeHash?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions