Skip to content

hashes is an epic PITA to work on #2197

@tcharding

Description

@tcharding

We introduced the macros because we had so much duplicate code that every change had to be done in loads of places (each of the individual hash modules). This was a win, however we now have a two different problems:

  1. The codebase is a massive PITA to work on (see below)
  2. The code is basically illegible to the casual reader

I've had multiple goes at #1552 and everything I try inevitable leads to having to do massive, invasive, exploritory changes to the macros which is a total pain in the arse and an epic time sink.

If we want to release a stable version of this crate, bug free, ergonomic, and usable for some time to come, should we consider removing the macros? Maybe we should fork the repo (or branch off), reduce it to one or two hash types, and come up with the API we want to stabalise with?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions