Replies: 3 comments 3 replies
-
|
I'm with you and think deprecated code shouldn't be kept indefinitely. It would cause the codebase to eventually become too bloated and hard to maintain. Major releases like |
Beta Was this translation helpful? Give feedback.
-
|
I vote yes, let's keep deprecated code. In almost all cases these deprecated functions are 1-3 lines of code and cost nearly nothing to maintain. But it's not a strong feeling. If people want a clean API I can understand wanting to clear them out. In that case I'd like the offending functions to be in a 0.32.x release for at least 3 months to give people time to migrate. |
Beta Was this translation helpful? Give feedback.
-
|
Oh I figured they stay in 0.32.x releases for ever |
Beta Was this translation helpful? Give feedback.
-
|
( |
Beta Was this translation helpful? Give feedback.
-
|
Yes -- they will be in 0.32.x forever. I just meant that when we release 1.0, we should keep anything that we only deprecated in 0.32.x very recently. Though now that I say that, it seems a bit silly...there's no reason that users can't just delay their own upgrade. We will say in the 1.0 release notes that people should first upgrade to the 0.32.x and fix all the deprecation warnings. |
Beta Was this translation helpful? Give feedback.
-
|
I don't know about the soft policy agreement, although I don't get the argument for keeping it around forever. The deprecated code might all be small easy to maintain 3 liners or so, although that could change. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I believe we now have a soft policy in
rust-bitcointo keep deprecated code around indefinitely. What about for the upcoming1.0releases (hashes,units,primitivesetc). Are we keeping deprecated in those?FTR I rekon that we should not.
Beta Was this translation helpful? Give feedback.
All reactions