Revert encode_to_fmt API change#77
Conversation
|
Should this be merged into |
|
I think we should just merge into master and later revert it. No need for extra process for such a low-activity crate. |
|
Can you rebase now that #76 is merged? |
Maintaining the original error type allows for making a minor release since it won't break the API. This lets indirect consumers of the crate through rust-bitcoin's module re-export to use new functions (e.g., encode_without_checksum) without a new rust-bitcoin release.
8e7fdce to
3693935
Compare
|
If you add a commit which bumps the minor version number I can publish a release right after merging. |
|
Thanks! Tagged, signed and published. |
Thanks for the quick turnaround on this! I had to add an explicit dependency in our crate otherwise I'd still get 0.9.0 from |
|
Did you try |
|
Ah, right. 😅 Forgot the |
Maintaining the original error type allows for making a minor release since it won't break the API. This lets indirect consumers of the crate through
rust-bitcoin's module re-export to use new functions (e.g.,encode_without_checksum) without a newrust-bitcoinrelease.