Skip to content

Implement TryFrom#68

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:07-27-try-from
Feb 28, 2023
Merged

Implement TryFrom#68
apoelstra merged 1 commit intorust-bitcoin:masterfrom
tcharding:07-27-try-from

Conversation

@tcharding
Copy link
Copy Markdown
Member

@tcharding tcharding commented Jul 27, 2022 •
edited
Loading

Now that we have MSRV 1.41.1 we can use TryFrom. Implement TryFrom for u5 with the code that was in try_from_u8.

@tcharding tcharding marked this pull request as ready for review July 29, 2022 01:48
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Aug 10, 2022

Changes in force push: Remove initial patch (which should never have been here).

@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Aug 10, 2022

Rebase and run formatter.

@tcharding tcharding mentioned this pull request Aug 11, 2022
Merged
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Aug 25, 2022

Rebase only, no other changes.

@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Oct 5, 2022

Rebase only, no other changes.

@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Oct 25, 2022

Gentle bump, can I get a review please crew.

@tcharding tcharding mentioned this pull request Feb 27, 2023
Merged
@apoelstra
Copy link
Copy Markdown
Member

apoelstra commented Feb 28, 2023

utACK 0c3059c but needs rebase.

@tcharding
Implement TryFrom<u8> for u5
bd651bb 
Now that we have MSRV 1.41.1 we can use `TryFrom`.

Implement TryFrom<u8> for `u5` with the code that was in `try_from_u8`.
@tcharding
Copy link
Copy Markdown
Member Author

tcharding commented Feb 28, 2023

Rebase only, no other changes.

apoelstra
apoelstra approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bd651bb

@apoelstra apoelstra merged commit 8f83401 into rust-bitcoin:master Feb 28, 2023
@tcharding tcharding deleted the 07-27-try-from branch March 1, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tcharding @apoelstra