Merged
Conversation
ecc59f2 to
3396f53
Compare
Contributor
Author
|
The last force-push reduced the files needed for the embedded CI test as suggested in rust-bitcoin/bitcoin_hashes#120 (comment) |
Contributor
Author
|
the latest push actually execute (not just build) the embedded process in CI |
devrandom
approved these changes
May 5, 2021
devrandom
left a comment
There was a problem hiding this comment.
ACK
Tested as part of my upcoming no_std PR for rust-bitcoin on both 1.29 and stable.
Contributor
Author
|
Hi devrandom, there is a relevant discussion on rust-bitcoin/bitcoin_hashes#120 about how to implement no_std on rust-bitcoin, in particular for handling |
TheBlueMatt
approved these changes
May 5, 2021
clarkmoody
approved these changes
May 5, 2021
Member
clarkmoody
left a comment
There was a problem hiding this comment.
Thanks for making this work 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's different from #46 because MSRV with std is still 1.29, while for no_std the MSRV is 1.36 because it uses
alloc.Includes a test in CI building a no_std embedded program (the test requires nightly because of the allocator used).
The embedded test is not run (only built) because there are issues with emulating arm on github action env.