Add impl_fmt_traits macro#90
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom May 20, 2024
Merged
Conversation
Member
Author
|
PR is tested in rust-bitcoin/rust-bitcoin#2770 |
52d907b to
a06b7ed
Compare
Member
|
In a06b7ed: Concept ACK. But
impl_fmt_traits! {
#[reverse(true)] // or whatever
impl<T: Whatever> all_fmt_traits for MyType<T> {
const LENGTH: usize = 32;
}
} |
Member
Author
|
|
4ba1693 to
7ddf1c0
Compare
Add a macro that implements the `fmt::{LowerHex, UpperHex, Display,
Debug}` traits. Includes support for displaying backwards.
Collaborator
|
@apoelstra that's impossible because you can't write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a macro that implements the
fmt::{LowerHex, UpperHex, Display, Debug}traits. Includes support for displaying backwards.Context
In
bitcoin_hasheswe have two versions of this code, moving it here is better because it is general hex related code. Note however that the reason for supporting display backwards might see strange unusual to the casual reader.Note
Note please the use of naked
core::fooin the macro requiringcoreto be in scope, is this reasonable of should we do the ugly re-export stuff we do inbitcoin_hashes:$crate::_export::_core::foo?