Merged
Conversation
Done in preparation for making the `iter` module public. We want the API to be as small as possible to give maximum maintenance flexibility. The `from_pairs` function is used internally and does not need to be public. We expect users to construct the `HexToBytesIter` using `new`.
We did not include the `HexSliceToBytesIter` alias in the 1.0 release. Remove mention of it from docs.
The module contains exactly two types, the `HexToBytesIter` and the helper `HexDigitsIter`. The former can only be constructed using `new` and the latter does not provide a constructor. It is meant for usage only if one needs to refer to the iter type explicitly as `HexToBytesIter<HexDigitsIter>`.
Member
Author
|
Woops wrong base. |
Member
Author
|
Note no CI here when targeting 1.x branch. |
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do a couple of preparatory patches then make the module pubic as well as the
HexToBytesIter::newconstructor. With this applied exactly two types will be added to the public API:HexToBytesIterand the helperHexDigitsIter. The former can only be constructed usingnewand the latter does not provide a constructor. It is meant for usage only if one needs to refer to the iter type explicitly asHexToBytesIter<HexDigitsIter>.Note we do not add the
HexSliceToBytesIteralias from master. If required that can be done as a follow up because as is this PR only touches code on the 1.x branch already.