This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Implement Hash::engine() for hash newtypes#93
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Oct 7, 2020
Merged
Conversation
Instead of the default implementation of `Engine::default()`.
Collaborator
Author
|
Strictly this is a breaking change, but it's only breaking for users of the tagged hashes, which I think there's none. Anyway, I'm patient on this one, because it's only relevant for taproot anyway. |
Member
|
I disagree that this is a breaking change. There is a visible change in the behavior of the |
apoelstra
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the default implementation of
Engine::default().This is needed to make newtypes with with
sha256ttagged hashes for taproot.