Turn libsqlite3-sys in a !#[no_std] crate#1765
Closed
weiznich wants to merge 1 commit intorusqlite:masterfrom
Closed
Turn libsqlite3-sys in a !#[no_std] crate#1765weiznich wants to merge 1 commit intorusqlite:masterfrom
!#[no_std] crate#1765weiznich wants to merge 1 commit intorusqlite:masterfrom
Conversation
There is no reason why this bindings crate needs std lib support. We can just instruct bindgen to generate imports for the relevant core types instead. This is the first step to run libsqlite3-sys in a no-std environment.
Collaborator
|
I've regenerated the remaining bindgen files here: #1767 diff --git a/libsqlite3-sys/upgrade.sh b/libsqlite3-sys/upgrade.sh
index d44e91c..b1d94a4 100755
--- a/libsqlite3-sys/upgrade.sh
+++ b/libsqlite3-sys/upgrade.sh
@@ -9,8 +9,8 @@ export SQLITE3_LIB_DIR="$SCRIPT_DIR/sqlite3"
mkdir -p "$TARGET_DIR" "$SQLITE3_LIB_DIR"
# Download and extract amalgamation
-SQLITE=sqlite-amalgamation-3510100
-curl -O https://sqlite.org/2025/$SQLITE.zip
+SQLITE=sqlite-amalgamation-3340100
+curl -O https://sqlite.org/2021/$SQLITE.zip
unzip -p "$SQLITE.zip" "$SQLITE/sqlite3.c" > "$SQLITE3_LIB_DIR/sqlite3.c"
unzip -p "$SQLITE.zip" "$SQLITE/sqlite3.h" > "$SQLITE3_LIB_DIR/sqlite3.h"
unzip -p "$SQLITE.zip" "$SQLITE/sqlite3ext.h" > "$SQLITE3_LIB_DIR/sqlite3ext.h"launch it and move the generated files... |
Contributor
Author
|
Thanks for the fast fix and thanks for explaining how it works. That's really appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason why this bindings crate needs std lib support. We can just instruct bindgen to generate imports for the relevant core types instead.
This is the first step to run libsqlite3-sys in a no-std environment.
For now this is marked as a draft to get some feedback on the idea itself and because https://github.com/rusqlite/rusqlite/blob/master/libsqlite3-sys/bindgen-bindings/bindgen_3.34.1.rs is not converted yet. Any pointer/documentation on how to regenerate this file would be helpful