Remove shell scripts from the published package#1744
Conversation
libsqlite3-sys/Cargo.toml
Outdated
| "sqlite3/sqlite3.h", | ||
| "sqlite3/sqlite3ext.h", | ||
| "sqlite3/wasm32-wasi-vfs.c", | ||
| ] |
There was a problem hiding this comment.
exclude would be better, no ?
Like
Lines 15 to 22 in 9d701b6
There was a problem hiding this comment.
I personally prefer include as it's explicit about what should be in the published package and what not. exclude kind of suffers of the same problem that none of these configs also have: There is still the possibility that something unexpected ends up in the package, include at least makes the decision conscious.
Now include on the other hand has the obvious problem that it can miss files. You can sidestep that by just running cargo package (with all relevant features) as part of the CI setup. That fails if something is missing.
There was a problem hiding this comment.
@gwenn I still wait on your decision here
|
Sorry, |
This commit removes shell scripts from the published package. These were reported by cargo denys `bans.build.interpreted` setting and they seem to be not required for building the crate.
edc376e to
f786ddf
Compare
|
No worries, you are the maintainer here so if you prefer it a certain way that's fine. |
|
Thanks. |
This commit removes shell scripts from the published package. These were reported by cargo denys
bans.build.interpretedsetting and they seem to be not required for building the crate.