Use CARGO_CFG_TARGET_FEATURE for crt-static check#1737
Merged
gwenn merged 3 commits intorusqlite:masterfrom Sep 29, 2025
Merged
Use CARGO_CFG_TARGET_FEATURE for crt-static check#1737gwenn merged 3 commits intorusqlite:masterfrom
gwenn merged 3 commits intorusqlite:masterfrom
Conversation
This change checks crt-static in the CARGO_CFG_TARGET_FEATURE environment variable instead of directly using the cfg!() macro. These can differ when cross-compiling from another platform.
d1bfb43 to
f8b79b5
Compare
This reverts commit f8b79b5.
Contributor
Author
|
AppVeyor CI is currently failing on this, but this is not caused by the change. Here is a PR with essentially nothing changed which also fails: #1738 |
Collaborator
|
I know nothing about cross-compilation but... |
gwenn
approved these changes
Sep 29, 2025
Collaborator
|
Unrelated but it seems that static build is not tested at all: rusqlite/.github/workflows/main.yml Line 85 in eb9c538
should be
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change checks crt-static in the CARGO_CFG_TARGET_FEATURE environment variable instead of directly using the cfg!() macro. These can differ when cross-compiling from another platform.