Bump minimal SQLite version to 3.34.1#1733
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1733 +/- ##
==========================================
- Coverage 86.91% 86.90% -0.01%
==========================================
Files 58 58
Lines 10642 10636 -6
==========================================
- Hits 9249 9243 -6
Misses 1393 1393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
When I opened #1731, I assumed the minimum supported version of SQLite was so old because there's people out there who depend on that. I've encountered at least one such person: launchbadge/sqlx#3905 (comment) I'm not against this, but you might end up with some people crawling out of the woodwork to yell at you about it. |
|
That's funny because I am currently using an older version of MacOS (BigSur 11.7.10) without any issue (with this PR): % which sqlite3
/usr/bin/sqlite3
% sqlite3
SQLite version 3.32.3 2020-06-18 14:16:19
% cargo test --all --all-targets
...(In fact, there is an issue but it is related to |
Fix #1731