Skip to content

Bump minimal SQLite version to 3.34.1#1733

Merged
gwenn merged 3 commits intorusqlite:masterfrom
gwenn:min_sqlite_version_3_34_1
Nov 23, 2025
Merged

Bump minimal SQLite version to 3.34.1#1733
gwenn merged 3 commits intorusqlite:masterfrom
gwenn:min_sqlite_version_3_34_1

Conversation

@gwenn
Copy link
Collaborator

@gwenn gwenn commented Aug 30, 2025

Fix #1731

@gwenn
Copy link
Collaborator Author

gwenn commented Aug 30, 2025

@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.90%. Comparing base (fe44105) to head (13138a1).
⚠️ Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
libsqlite3-sys/build.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   86.91%   86.90%   -0.01%     
==========================================
  Files          58       58              
  Lines       10642    10636       -6     
==========================================
- Hits         9249     9243       -6     
  Misses       1393     1393              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abonander
Copy link

When I opened #1731, I assumed the minimum supported version of SQLite was so old because there's people out there who depend on that. I've encountered at least one such person: launchbadge/sqlx#3905 (comment)

I'm not against this, but you might end up with some people crawling out of the woodwork to yell at you about it.

@gwenn
Copy link
Collaborator Author

gwenn commented Sep 6, 2025

That's funny because I am currently using an older version of MacOS (BigSur 11.7.10) without any issue (with this PR):

% which sqlite3
/usr/bin/sqlite3
% sqlite3
SQLite version 3.32.3 2020-06-18 14:16:19
% cargo test --all --all-targets
...

(In fact, there is an issue but it is related to sqlite_schema #1734 and not related to min_sqlite_version_3_34_1)
So I guess that launchbadge/sqlx#3905 (comment) is not using the system library...

@gwenn gwenn merged commit 8010344 into rusqlite:master Nov 23, 2025
16 checks passed
@gwenn gwenn deleted the min_sqlite_version_3_34_1 branch November 23, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libsqlite3-sys: support 3.20 (or sqlite3_prepare_v3()) in pre-generated bindings

2 participants