Fix for vtab::parameter parsing#1712
Merged
gwenn merged 1 commit intorusqlite:masterfrom Jun 18, 2025
Merged
Conversation
gwenn
approved these changes
Jun 17, 2025
Contributor
Author
|
I guess I neglected to run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
+ Coverage 87.84% 87.86% +0.01%
==========================================
Files 58 58
Lines 11379 11380 +1
==========================================
+ Hits 9996 9999 +3
+ Misses 1383 1381 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Please do. |
vtab::parameter only needs to look for the first = to know where to split between the key and value as there may be values that also contain an '=' symbol.
Contributor
Author
|
Ok ran |
Collaborator
|
Thanks |
Collaborator
|
rusqlite version 0.37.0 released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vtab::parameter only needs to look for the first = to know where to split between the key and value as there may be values that also contain an '=' symbol.
This should fix #1711
I have only written some rust as a hobby, so please let me know if you would prefer it written a different way. I tried to copy the existing formats look.