Skip to content

Make statement cache optional#1682

Merged
gwenn merged 4 commits intorusqlite:masterfrom
gwenn:cache
Oct 4, 2025
Merged

Make statement cache optional#1682
gwenn merged 4 commits intorusqlite:masterfrom
gwenn:cache

Conversation

@gwenn
Copy link
Collaborator

@gwenn gwenn commented Apr 20, 2025

Related to #1173
Breaking change for all dependents that use default-features = false
Maybe we should provide a simple LRU cache impl (instead of no cache at all) like the one provided by default for the official TCL bindings which is based on a linked list.

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (06d76e4) to head (075f84e).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1682   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          58       58           
  Lines       10638    10641    +3     
=======================================
+ Hits         9245     9248    +3     
  Misses       1393     1393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gwenn added 3 commits August 10, 2025 08:16
As there is no SQLite library available / installed by default on
Windows, without the `bundled` feature, the build fails
@gwenn gwenn marked this pull request as ready for review October 4, 2025 08:40
@gwenn gwenn merged commit 3d7c36e into rusqlite:master Oct 4, 2025
16 checks passed
@gwenn gwenn deleted the cache branch October 4, 2025 08:40
@GuillerLT
Copy link

Am I doing something wrong or are the functions behind this feature not showing in the documentation?
https://docs.rs/rusqlite/0.38.0/rusqlite/?search=cache
Is this the desired behavior?

@gwenn
Copy link
Collaborator Author

gwenn commented Dec 23, 2025

Am I doing something wrong or are the functions behind this feature not showing in the documentation? https://docs.rs/rusqlite/0.38.0/rusqlite/?search=cache Is this the desired behavior?

Definitely not:
https://github.com/rusqlite/rusqlite/blob/master/Cargo.toml#L226-L228

features = ["modern-full", "rusqlite-macros"]
no-default-features = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants