Skip to content

added sqlite3_vtab_nochange() and sqlite3_value_nochange(x)#1664

Closed
abhay-agarwal wants to merge 1 commit intorusqlite:masterfrom
withpoly:sqlite_vtab_nochange_added
Closed

added sqlite3_vtab_nochange() and sqlite3_value_nochange(x)#1664
abhay-agarwal wants to merge 1 commit intorusqlite:masterfrom
withpoly:sqlite_vtab_nochange_added

Conversation

@abhay-agarwal
Copy link

I noticed that these methods were stubbed out, so I added them at very low cost. Perhaps I misunderstood why they were stubbed but if not, here they are.

@gwenn
Copy link
Collaborator

gwenn commented Mar 18, 2025

(1) You cannot assume that sqlite3_vtab_nochange is available because rusqlite use 3.14 API by default (see CI build error)
(2) Ideally, we should make sure that sqlite3_vtab_nochange is used only from xColumn
(3) src/context.rs is used only to share common code between functions and vtab which is clearly not the case of sqlite3_vtab_nochange
(4) Ideally, we should make sure that sqlite3_value_nochange is used only from xUpdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants