Skip to content

Introduce Name trait to support both &str and &CStr as name#1659

Merged
gwenn merged 8 commits intorusqlite:masterfrom
gwenn:named
Apr 20, 2025
Merged

Introduce Name trait to support both &str and &CStr as name#1659
gwenn merged 8 commits intorusqlite:masterfrom
gwenn:named

Conversation

@gwenn
Copy link
Collaborator

@gwenn gwenn commented Mar 2, 2025

  • remove DatabaseName ?
  • fix db_filename (unsound ?)
  • how to fix Option<Name> impact ?

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (14f0eda) to head (c2c1d02).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/lib.rs 50.00% 6 Missing ⚠️
src/inner_connection.rs 66.66% 3 Missing ⚠️
src/session.rs 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
+ Coverage   86.91%   86.95%   +0.04%     
==========================================
  Files          58       58              
  Lines       11136    11110      -26     
==========================================
- Hits         9679     9661      -18     
+ Misses       1457     1449       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwenn gwenn marked this pull request as ready for review April 20, 2025 09:44
@gwenn gwenn merged commit cd43f65 into rusqlite:master Apr 20, 2025
16 checks passed
@gwenn gwenn deleted the named branch April 20, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant