Support wasm32-unknown-unknown target#1643
Conversation
wasm32-unknown-unknown target
bcab28c to
8bc5f00
Compare
|
I know nothing about wasm so we need to find someone kind enough to validate this PR. |
Of course, I will add the tests runner to CI/CD later today, currently all the tests pass (except a couple that require |
(a) (b) This file is used to compile sqlite3 into emscripten wasm, mainly for generating bindings in emscripten js. We don't need it, we have enabled |
|
The tests have been added to the CI/CD (approval is required to verify whether they work). All tests have passed in local testing. |
|
Thanks for your time and explanations. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1643 +/- ##
==========================================
- Coverage 86.90% 82.08% -4.82%
==========================================
Files 58 58
Lines 10638 7398 -3240
==========================================
- Hits 9245 6073 -3172
+ Misses 1393 1325 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fixed CI for By the way, why does the CI process require approval? It seems that it is not convenient to find problems and fix CI. |
Maybe because a patched / malicious |
Reasonable. I need to rerun CI now to verify whether everything passes. Can you approve it? |
You can enable Actions on your fork and get CI to run inside your account instead of from the PR. |
Thanks! |
|
CI have passed: https://github.com/Spxg/rusqlite/actions/runs/13284078817/job/37088729090, cov failed because I didn’t have a token to upload. (thanks to @trevyn ) I'm ready for the review. |
|
Because of breaking changes, sqlite-wasm-rs is updated to 0.3
|
Any suggestions? |
|
This PR is exactly what I need for one of my projects, so I hope someone can validate it soon. I can at least confirm @Spxg 's fork works without issue when used as a dependency in a project targeting |
Users can override features in their own Cargo.toml
|
@gwenn any suggestions? |
|
Just for reference: |
Yes, |
Which means the official sqlite3.wasm ? |
This means we can compile However, this is only one step, more work is actually to implement a persistent VFS under If you are interested, you can try it out at https://sqlight.dev |
Of course, another important work is to complete some C functions: |
|
Ok, thanks for the details. |
I don't know if it can be implemented this way.