Update error type for ValueRef methods#1629
Merged
gwenn merged 1 commit intorusqlite:masterfrom Jan 27, 2025
Merged
Conversation
Collaborator
|
You are right. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1629 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 56 56
Lines 10912 10912
=======================================
Hits 9452 9452
Misses 1460 1460 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the doc comments that explain the error variant returned by
ValueRefmethods.The current doc comments say that the methods will return
Err(Error::InvalidColumnType)if the case ofselfis not correct. TheErrcase of the results returned by these methods is actuallyFromSqlError, and specificallyFromSqlError::InvalidTypewhen the case ofselfis not correct.I had a quick glance at every line matching
//.*Error::and//.*Err\(and could not find any other comments that seemed incorrect.