Fixed pre-release wasm32-wasip(\d) targets not enabling wasi compile flags in bundled mode.#1569
Conversation
…mode. wasm32-wasi is being deprecated in favor of pre-release targets like `wasm32-wasip\d`. This instead matches the prefix wasi target, so any future pre-releases will probably, maybe work out of the box.
wasm32-wasi(\d) targets not enabling wasi compile flags in bundled mode.
wasm32-wasi(\d) targets not enabling wasi compile flags in bundled mode.wasm32-wasip(\d) targets not enabling wasi compile flags in bundled mode.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1569 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 57 57
Lines 10670 10670
=======================================
Hits 9168 9168
Misses 1502 1502 ☔ View full report in Codecov by Sentry. |
|
@thomcc If possible, could you please help me validate this PR (because I know nothing about wasm) ? |
|
As a note on this, wasm32-wasi was supported previously, that target was renamed to wasm32-wasip1, which is what caused the build issue. The target itself is the same to my knowledge. For that build target at least, this would be identical. There is p2 on nightly, but my goal here was getting the renamed version of p1 building. |
|
Sorry for the delay. |
The
wasm32-wasitarget is being deprecated in favor of pre-release targets likewasm32-wasip(\d).This instead matches the prefix wasi target, so any future pre-releases will probably, maybe, work out of the box.