Skip to content

fix: build should support lib64 dir for OpenSSL3.x#1502

Merged
gwenn merged 2 commits intorusqlite:masterfrom
richerfu:master
May 24, 2024
Merged

fix: build should support lib64 dir for OpenSSL3.x#1502
gwenn merged 2 commits intorusqlite:masterfrom
richerfu:master

Conversation

@richerfu
Copy link
Contributor

@richerfu richerfu commented May 13, 2024

No description provided.

gwenn
gwenn reviewed May 13, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.27%. Comparing base (6218aa4) to head (a7d5d33).

❗ Current head a7d5d33 differs from pull request most recent head 1886a0a. Consider uploading reports for the commit 1886a0a to get more accurate results

Files Patch % Lines
libsqlite3-sys/build.rs 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   85.33%   85.27%   -0.06%     
==========================================
  Files          54       54              
  Lines       10454    10461       +7     
==========================================
  Hits         8921     8921              
- Misses       1533     1540       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richerfu
Copy link
Contributor Author

richerfu commented May 21, 2024

Hi how about to merge this pr? Thanks

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 85.22%. Comparing base (6218aa4) to head (1886a0a).
Report is 6 commits behind head on master.

Files Patch % Lines
libsqlite3-sys/build.rs 5.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   85.33%   85.22%   -0.11%     
==========================================
  Files          54       54              
  Lines       10454    10467      +13     
==========================================
  Hits         8921     8921              
- Misses       1533     1546      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gwenn gwenn merged commit b1b26af into rusqlite:master May 24, 2024
@gwenn
Copy link
Collaborator

gwenn commented May 24, 2024

Thanks.

@gwenn
Copy link
Collaborator

gwenn commented Jun 22, 2024

libsqlite3-sys v0.29.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gwenn gwenn gwenn left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@richerfu @codecov-commenter @gwenn