Closed
Conversation
gwenn
reviewed
Feb 13, 2023
| /// See [`win_target`] | ||
| fn is_compiler(compiler_name: &str) -> bool { | ||
| env::var("CARGO_CFG_TARGET_ENV").map_or(false, |v| v == compiler_name) | ||
| env::var("TARGET").map_or(false, |v| v == compiler_name) |
Collaborator
There was a problem hiding this comment.
I am not sure but for me this changes breaks cross compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CARGO_CFG_TARGET_ENVis not being set when compiling towasm32-wasiand if it isn't then the flags used for compiling sqlite correctly for it do not get applied. We can useTARGETinstead, which seems to be always set.Also,
-DSQLITE_THREADSAFE=0is needed as a flag, as without it, sqlite will usepthread.hwhich is not defined for wasi targets.