Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On threads, don't pull User information. This speeds up a
resume -threadssignificantly.This issue fixes one of the root causes of the slowness reported in #560
The effect of this PR is similar to #646. #646 uses caching while this skips it entirely. As a result it is unclear how beneficial #646 really is.
Speed testing
4.1.0 takes 24sec
% ./slackdump-4.1.0 \ resume \ -threads \ test-slackdump-dev ... 0.69user 0.47system 0:24.44elapsed 4%CPU (0avgtext+0avgdata 52144maxresident)k 0inputs+91440outputs (0major+10474minor)pagefaults 0swapsWithout fetching the user it only takes 8 seconds.
% ./slackdump-this-pr \ resume \ -threads \ test-slackdump-dev ... 0.49user 0.30system 0:08.73elapsed 9%CPU (0avgtext+0avgdata 50488maxresident)k 0inputs+53792outputs (0major+8918minor)pagefaults 0swaps