Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #603 where avatar downloads fail with 403 Forbidden errors when Slack returns avatar URLs containing double periods before the file extension (e.g., original..jpg).
Changes:
- Added
removeDoubleDotsmethod to strip extra periods from avatar URLs before downloading - Added comprehensive test coverage for the new method including edge cases (empty strings, no extension, non-ASCII characters)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/convert/transform/fileproc/avatar.go | Implements removeDoubleDots method and applies it to avatar URLs before download |
| internal/convert/transform/fileproc/avatar_test.go | Adds comprehensive test cases for the new removeDoubleDots method |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603