Update to latest Flank#334
Merged
Merged
Conversation
Owner
|
There's a few other place to update here as well can you do a find and replace on that version number in the project? |
Contributor
Author
|
Yup! I think I got everything There's a few other trailing versions specified for integration + validation test. If you'd like those too I can push up another commit Tested locally and seem to be passing, fit within the assertions for everything except the test covering non-existent Flank versions (as expected) |
runningcode
approved these changes
Aug 16, 2023
This was referenced Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to latest Flank version for correct test time calculations Flank/flank#2364
Ran test locally, we are already running with this through flankVersion and seems to be working well