fix quickfix for 'no-missing-import' on windows.#110
Merged
runem merged 4 commits intorunem:1.2.0from Jul 4, 2020
FelixSchuSi:1.2.0
Merged
fix quickfix for 'no-missing-import' on windows.#110runem merged 4 commits intorunem:1.2.0from FelixSchuSi:1.2.0
runem merged 4 commits intorunem:1.2.0from
FelixSchuSi:1.2.0
Conversation
Owner
|
Thank you very much for this fix, it looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows, the quickfixes suggested by the "no-missing-import" rule generate broken paths when dealing with nested folders.
In a project with a structure like this:
parent.ts children └─1 └─folder └─another-folder child1.tsWhen you generate an import for child1.ts inside of parent.ts your get this statement:
This doesnt work since imports require UNIX-like file paths with forward slashes.
This PR fixes the bug.
The generated import statement now looks like this: