Conversation
| } | ||
|
|
||
| // ExportForNode exports labels for a specific node | ||
| func (e *MultiNodeLabelsExporter) ExportForNode(nodeName string, nodeTopology *topology.NodeTopology) error { |
There was a problem hiding this comment.
I'd consider naming it SetLabelsForNode, the name ExportForNode is not intuitive for something that sets the labels and only returns an error, I'd expect this func to "export" something from the nodes
Comment on lines
+87
to
+91
| for nodeName, nodeTopology := range snapshot { | ||
| if err := e.exportNode(nodeName, nodeTopology); err != nil { | ||
| log.Printf("Failed to refresh metrics for node %s: %v\n", nodeName, err) | ||
| } | ||
| } |
There was a problem hiding this comment.
If that's a slow operation (not sure how slow), perhaps we can start a go routine that does it, and start it within the lock? That way we just trigger the sending of metrics every 10 seconds, and the sending itself happens in a separate go routine and takes how long it needs
Contributor
Author
There was a problem hiding this comment.
removed the comment, it was irrelevant
…lock in MultiNodeMetricsExporter
JRosenboimNVIDIA
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.