Eliranw/run 34335 - Add KWOK deployment for DRA resources#144
Merged
Conversation
- Add kwok-dra-plugin component that watches topology ConfigMaps and creates ResourceSlices - Add Helm templates for kwok-dra-plugin deployment with RBAC - Add integration tests for KWOK node GPU scheduling - Update README with KWOK integration documentation - Add KWOK stages and test manifests for integration testing
8193176 to
0f2875c
Compare
iris-shain-runai
approved these changes
Dec 17, 2025
| // ResourceSliceHandler handles ResourceSlice operations for KWOK nodes | ||
| type ResourceSliceHandler struct { | ||
| kubeClient kubernetes.Interface | ||
| clusterTopology *topology.ClusterTopology |
There was a problem hiding this comment.
looks like this is never used
- Removed the topology package from the KWOK DRA plugin, simplifying the ConfigMap reconciler setup. - Updated ResourceSliceHandler to eliminate the clusterTopology parameter, streamlining its initialization. - Adjusted related tests to reflect the removal of the topology dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.