Create a lease for the snapshots we prepare #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a lease we make sure that containerd won't garbage collect out snapshot. We remove the lease when the container is removed and leave it to containerd to clean things up. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
vvoland
approved these changes
Aug 17, 2022
thaJeztah
reviewed
Sep 1, 2022
Comment on lines
+197
to
+206
| // Add a lease so that containerd doesn't garbage collect our snapshot | ||
| ls := daemon.containerdCli.LeasesService() | ||
| lease, err := ls.Create(ctx, leases.WithID(ctr.ID)) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ls.AddResource(ctx, lease, leases.Resource{ | ||
| ID: ctr.ID, | ||
| Type: "snapshots/" + daemon.graphDriver, | ||
| }) |
Collaborator
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a lease we make sure that containerd won't garbage collect out
snapshot. We remove the lease when the container is removed and leave it
to containerd to clean things up.