let buildx know we support containerd snapshotter#50
Merged
Conversation
rumpl
approved these changes
Aug 9, 2022
Owner
rumpl
left a comment
There was a problem hiding this comment.
LGTM, @tonistiigi @crazy-max LGTY?
vvoland
approved these changes
Aug 9, 2022
| @@ -78,7 +78,9 @@ func newSnapshotterController(rt http.RoundTripper, opt Opt) (*mobycontrol.Contr | |||
| snapshotter := ctd.DefaultSnapshotter | |||
Collaborator
There was a problem hiding this comment.
LGTM, but please rebase on #40 for this to be configured instead of hardcoded containerd snapshotter
Collaborator
|
Yes that SGTM! |
crazy-max
reviewed
Aug 9, 2022
builder/builder-next/controller.go
Outdated
| wo, err := containerd.NewWorkerOpt(opt.Root, opt.ContainerdAddress, snapshotter, opt.ContainerdNamespace, | ||
| opt.Rootless, map[string]string{}, dns, nc, opt.ApparmorProfile, nil, "", ctd.WithTimeout(60*time.Second)) | ||
| opt.Rootless, map[string]string{ | ||
| "org.mobyproject.buildkit.worker.snapshotter": snapshotter, |
Collaborator
There was a problem hiding this comment.
Could you use LabelSnapshotter instead: https://github.com/moby/buildkit/blob/86c33b66e176a6fc74b88d6f46798d3ec18e2e73/worker/worker.go#L50
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Create moby builder with a special label to let buildx know we use containerd snapshotter and it can enable features accordingly