daemon/containerd: fix compat for "docker run" with image that's not present #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
approved these changes
Dec 8, 2022
Collaborator
Author
Looks like we need moby#44571 |
Collaborator
Author
|
opened #123 to fix CI |
…present
It's horrible, but some clients (such as the docker 17.03 CLI used in CI) still
perform string-matching to detect that the *image* wasn't found. This requires
the error to be prefixed with "No such image:". Without this prefix, the CLI
prints the error message, and exits.
Before this:
docker run -it --rm hello-world
docker: Error response from daemon: id not found.
See 'docker run --help'.
After this:
docker run -it --rm hello-world
Unable to find image 'hello-world:latest' locally
faa03e786c97: Download complete
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5553bbe to
a5a01b5
Compare
Collaborator
Author
|
Rebased after #123 was merged; CI should (hopefully) go green now 👍 |
Collaborator
Author
|
All green 🎉 bringing this one in 👍 |
Collaborator
Author
|
This should be upstreamed together with |
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's horrible, but some clients (such as the docker 17.03 CLI used in CI) still perform string-matching to detect that the image wasn't found. This requires the error to be prefixed with "No such image:". Without this prefix, the CLI prints the error message, and exits.
Before this:
After this:
- A picture of a cute animal (not mandatory but encouraged)