client-api: Add registration token validity checking endpoint#757
Merged
client-api: Add registration token validity checking endpoint#757
Conversation
jplatte
reviewed
Nov 9, 2021
Member
jplatte
left a comment
There was a problem hiding this comment.
Thanks! Looks good overall, only some minor things need to be adjusted.
crates/ruma-client-api/src/r0/account/registration_token_validity.rs
Outdated
Show resolved
Hide resolved
jplatte
reviewed
Nov 9, 2021
Member
|
@govynnus Can you rerun |
auto-merge was automatically disabled
November 9, 2021 12:16
Head branch was pushed to by a user without write access
Contributor
Author
|
No problem, sorry it took so long :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed in MSC3231
https://github.com/matrix-org/matrix-doc/blob/main/proposals/3231-token-authenticated-registration.md#checking-the-validity-of-a-token
Closes #708
I only put the
unstable-pre-specattributes inaccount.rs, which I'm not sure is correct.Also I couldn't find anywhere endpoints are tested (but didn't look very hard).