Implement MSC3231: Token authenticated registration#722
Merged
Conversation
jplatte
reviewed
Sep 21, 2021
Member
jplatte
left a comment
There was a problem hiding this comment.
This is one of the highest-quality first contributions I've seen on this repo. Thank you!
There's only a few minor things to be adjusted, see below.
Member
|
I will squash-merge this as is because it makes for a good atomic commit. Please open a separate PR for the new endpoint (and a changelog entry, ideally) :) |
Contributor
Author
|
Ok, I'll try get to it this week :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for registration tokens as described in MSCS3231
asd
#708
- Add endpoint for checking the validity of tokens