Loosen type of call member event state keys#1885
Merged
Conversation
Allow MSC3401-style call membership state events to have state keys that are arbitrary strings, and not just pure MXIDs. This allows for state keys that are suffixed with the sender's device ID, as well as ones prefixed by an underscore to bypass auth rules over state keys that start with a `@` but do not strictly equal an MXID.
zecakeh
approved these changes
Aug 10, 2024
Contributor
zecakeh
left a comment
There was a problem hiding this comment.
Looks good! Eventually, we'll probably want to use an enum with the different possibilities, but this should be good for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow MSC3401-style call membership state events to have state keys that are arbitrary strings, and not just pure MXIDs.
This allows for state keys that are suffixed with the sender's device ID, as well as ones prefixed by an underscore to bypass auth rules over state keys that start with a
@but do not strictly equal an MXID.