Future Events: Add future endpoints to ruma.#1845
Merged
Conversation
52dbef8 to
9ae13f0
Compare
76607d6 to
9a08459
Compare
zecakeh
reviewed
Jun 19, 2024
Contributor
zecakeh
left a comment
There was a problem hiding this comment.
I tried to do a thorough review but avoid to repeat the same comments if it seemed like the code was copy-pasted, so some comments on docs might need to be fixed in other places too.
11a2c3b to
ccdd564
Compare
zecakeh
reviewed
Jun 19, 2024
d722405 to
561a516
Compare
zecakeh
reviewed
Jun 20, 2024
Contributor
|
Alright, if you rebase on main we should be good to go. |
8fca79e to
853197a
Compare
28b5c6f to
6a2ab00
Compare
zecakeh
approved these changes
Jun 24, 2024
Contributor
|
Ah we are just missing a changelog entry now. |
Contributor
Author
|
I added a change-log entry. |
zecakeh
reviewed
Jun 25, 2024
1fec53d to
6515128
Compare
zecakeh
reviewed
Jun 25, 2024
6515128 to
3befe56
Compare
Contributor
|
Thanks for this! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on: #1848
This implements the required endpoint for MSC4140.
This is the first step to make the widget api support
Futuresand will be used in the rust-sdk widget driver.