refactor: rename source file and folder hierarchy #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the codebase by reorganizing the flat module structure into a hierarchical structure with better organization and clearer separation of concerns.
Changes:
- Reorganized modules into logical groups:
utils(helper utilities),mux(multiplexing functionality), anddemux(demultiplexing functionality) - Renamed helper modules to be under the
utilsnamespace (e.g.,gilrs_helper→utils::gilrs,evdev_helpers→utils::evdev,ff_helpers→utils::ff,udev_helpers→utils::udev) - Updated all import paths throughout the codebase to reflect the new module hierarchy
Reviewed changes
Copilot reviewed 23 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Updated module declarations and import paths; critical issue found with DemuxRumbleTarget re-export |
| src/utils/mod.rs | New module file declaring public utility modules |
| src/utils/gilrs.rs | Moved from gilrs_helper.rs; added pub use for GamepadId and Gilrs |
| src/utils/udev.rs | Moved from udev_helpers.rs; updated import path |
| src/utils/ff.rs | Moved from ff_helpers.rs; updated import path |
| src/utils/evdev.rs | Moved from evdev_helpers.rs; contains helper functions for evdev device creation and mapping |
| src/mux/mod.rs | New module file declaring mux submodules |
| src/mux/manager.rs | Moved from mux_manager.rs; updated all import paths |
| src/mux/runtime.rs | Moved from mux_runtime.rs; updated import paths and removed redundant use statement |
| src/mux/modes/mod.rs | Moved from mux_modes.rs; declares mode implementations |
| src/mux/modes/helpers.rs | Updated import paths to use new module structure |
| src/mux/modes/average.rs | Updated import paths and removed unused imports |
| src/mux/modes/priority.rs | Updated import paths and removed unused imports |
| src/mux/modes/toggle.rs | Updated import paths and removed unused imports |
| src/demux/mod.rs | New module file declaring demux submodules |
| src/demux/manager.rs | Moved from demux_manager.rs; updated all import paths |
| src/demux/runtime.rs | Moved from demux_runtime.rs; updated import paths and removed redundant use statement |
| src/demux/modes/mod.rs | Moved from demux_modes.rs; declares mode implementations |
| src/demux/modes/helpers.rs | Updated to re-export from new mux::modes::helpers location |
| src/demux/modes/multicast.rs | Updated import paths |
| src/demux/modes/unicast.rs | Updated import paths |
| src/tray/mod.rs | Changed submodules from private to public visibility |
| src/tray/app.rs | Updated all import paths to reflect new module structure |
| src/tray/config.rs | Updated import paths |
| src/tray/state.rs | Updated import paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.